From: Adrian Bunk <bunk@stusta.de>
This patch fixes a check after use found by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/fs/attr.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff -puN fs/attr.c~fs-attrc-fix-check-after-use fs/attr.c
--- 25/fs/attr.c~fs-attrc-fix-check-after-use 2005-03-24 18:23:17.000000000 -0800
+++ 25-akpm/fs/attr.c 2005-03-24 18:23:17.000000000 -0800
@@ -135,14 +135,17 @@ int setattr_mask(unsigned int ia_valid)
int notify_change(struct dentry * dentry, struct iattr * attr)
{
struct inode *inode = dentry->d_inode;
- mode_t mode = inode->i_mode;
+ mode_t mode;
int error;
- struct timespec now = current_fs_time(inode->i_sb);
+ struct timespec now;
unsigned int ia_valid = attr->ia_valid;
if (!inode)
BUG();
+ mode = inode->i_mode;
+ now = current_fs_time(inode->i_sb);
+
attr->ia_ctime = now;
if (!(ia_valid & ATTR_ATIME_SET))
attr->ia_atime = now;
_