Changes between v2.40-rc2 and v2.40
--------------------------------------------
commit c1c1ab8b8e67e04ee293d4cf5679430a5b174bb8
Author: Karel Zak <kzak@redhat.com>
Date: Wed Mar 27 12:46:59 2024 +0100
build-sys: release++ (v2.40)
Signed-off-by: Karel Zak <kzak@redhat.com>
NEWS | 8 ++++++--
configure.ac | 2 +-
meson.build | 2 +-
3 files changed, 8 insertions(+), 4 deletions(-)
commit 9b5d88b8254228da375efeaa059792ab064bbf4f
Author: Karel Zak <kzak@redhat.com>
Date: Wed Mar 27 12:43:32 2024 +0100
docs: update v2.40-ReleaseNotes
Signed-off-by: Karel Zak <kzak@redhat.com>
Documentation/releases/v2.40-ReleaseNotes | 58 +++++++++++++++++++++++++++++++
1 file changed, 58 insertions(+)
commit 404b0781f52f7c045ca811b2dceec526408ac253
Author: Karel Zak <kzak@redhat.com>
Date: Thu Mar 21 11:16:20 2024 +0100
wall: fix escape sequence Injection [CVE-2024-28085]
Let's use for all cases the same output function.
Reported-by: Skyler Ferrante <sjf5462@rit.edu>
Signed-off-by: Karel Zak <kzak@redhat.com>
term-utils/wall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit 2ff49aae8f2b30eba1d3a9d324183d5e3e531e5f
Author: Karel Zak <kzak@redhat.com>
Date: Wed Mar 27 12:16:05 2024 +0100
docs: update AUTHORS file
Signed-off-by: Karel Zak <kzak@redhat.com>
AUTHORS | 6 ++++++
1 file changed, 6 insertions(+)
commit 6b4f9900f618b97a3afc24d7923f1810a438193b
Author: Karel Zak <kzak@redhat.com>
Date: Wed Mar 27 12:12:37 2024 +0100
po-man: merge changes
Signed-off-by: Karel Zak <kzak@redhat.com>
po-man/cs.po | 4396 +++---
po-man/de.po | 33912 ++++++++++++++++++++++++++++++++++----------
po-man/es.po | 5434 ++++---
po-man/fr.po | 6760 ++++++---
po-man/pt_BR.po | 4689 +++---
po-man/sr.po | 7350 +++++++---
po-man/uk.po | 29784 +++++++++++++++++++++++++++++---------
po-man/util-linux-man.pot | 2943 ++--
8 files changed, 68734 insertions(+), 26534 deletions(-)
commit ae46304d52afb657c868a44a0011785641b710c8
Author: Karel Zak <kzak@redhat.com>
Date: Wed Mar 27 12:12:31 2024 +0100
po: merge changes
Signed-off-by: Karel Zak <kzak@redhat.com>
po/ca.po | 332 ++++++++++++++++++++++++++---------------------------
po/cs.po | 332 ++++++++++++++++++++++++++---------------------------
po/da.po | 332 ++++++++++++++++++++++++++---------------------------
po/de.po | 332 ++++++++++++++++++++++++++---------------------------
po/es.po | 332 ++++++++++++++++++++++++++---------------------------
po/et.po | 332 ++++++++++++++++++++++++++---------------------------
po/eu.po | 332 ++++++++++++++++++++++++++---------------------------
po/fi.po | 332 ++++++++++++++++++++++++++---------------------------
po/fr.po | 332 ++++++++++++++++++++++++++---------------------------
po/gl.po | 332 ++++++++++++++++++++++++++---------------------------
po/hr.po | 332 ++++++++++++++++++++++++++---------------------------
po/hu.po | 332 ++++++++++++++++++++++++++---------------------------
po/id.po | 332 ++++++++++++++++++++++++++---------------------------
po/it.po | 332 ++++++++++++++++++++++++++---------------------------
po/ja.po | 332 ++++++++++++++++++++++++++---------------------------
po/ko.po | 332 ++++++++++++++++++++++++++---------------------------
po/nl.po | 332 ++++++++++++++++++++++++++---------------------------
po/pl.po | 332 ++++++++++++++++++++++++++---------------------------
po/pt.po | 332 ++++++++++++++++++++++++++---------------------------
po/pt_BR.po | 332 ++++++++++++++++++++++++++---------------------------
po/ru.po | 332 ++++++++++++++++++++++++++---------------------------
po/sk.po | 332 ++++++++++++++++++++++++++---------------------------
po/sl.po | 332 ++++++++++++++++++++++++++---------------------------
po/sr.po | 332 ++++++++++++++++++++++++++---------------------------
po/sv.po | 332 ++++++++++++++++++++++++++---------------------------
po/tr.po | 332 ++++++++++++++++++++++++++---------------------------
po/uk.po | 332 ++++++++++++++++++++++++++---------------------------
po/util-linux.pot | 334 +++++++++++++++++++++++++++---------------------------
po/vi.po | 332 ++++++++++++++++++++++++++---------------------------
po/zh_CN.po | 332 ++++++++++++++++++++++++++---------------------------
po/zh_TW.po | 332 ++++++++++++++++++++++++++---------------------------
31 files changed, 5147 insertions(+), 5147 deletions(-)
commit 3f057f50949a474cac028cc1f69366220e930716
Author: Yuri Chornoivan <yurchor@ukr.net>
Date: Wed Mar 27 12:10:03 2024 +0100
po-man: update uk.po (from translationproject.org)
po-man/uk.po | 24251 ++++++++++++---------------------------------------------
1 file changed, 4870 insertions(+), 19381 deletions(-)
commit 4180878e70957e39bb0d5354f9bfd5ae6f01a739
Author: Remus-Gabriel Chelu <remusgabriel.chelu@disroot.org>
Date: Wed Mar 27 12:10:03 2024 +0100
po-man: update ro.po (from translationproject.org)
po-man/ro.po | 7285 ++++++++++++++++++++++++++++++++++------------------------
1 file changed, 4302 insertions(+), 2983 deletions(-)
commit 0bb9c134a51d9b604c8cbe947e7babff6ad7f1c2
Author: Mario Blättermann <mario.blaettermann@gmail.com>
Date: Wed Mar 27 12:10:03 2024 +0100
po-man: update de.po (from translationproject.org)
po-man/de.po | 27160 +++++++++++----------------------------------------------
1 file changed, 5210 insertions(+), 21950 deletions(-)
commit 9f63a20718d27fd2b1b7096f320007e6323d65cf
Author: Yuri Chornoivan <yurchor@ukr.net>
Date: Wed Mar 27 12:08:32 2024 +0100
po: update uk.po (from translationproject.org)
po/uk.po | 1129 +++++++++++++++++++-------------------------------------------
1 file changed, 348 insertions(+), 781 deletions(-)
commit b5117c6fb62c773697420779b752d7d6b498309a
Author: Remus-Gabriel Chelu <remusgabriel.chelu@disroot.org>
Date: Wed Mar 27 12:08:32 2024 +0100
po: update ro.po (from translationproject.org)
po/ro.po | 8617 +++++++++++++++++++++++++++++++++++---------------------------
1 file changed, 4855 insertions(+), 3762 deletions(-)
commit 6ac4bca93766bea4ed2090dd73ba947e52052fba
Author: Jakub Bogusz <qboosh@pld-linux.org>
Date: Wed Mar 27 12:08:32 2024 +0100
po: update pl.po (from translationproject.org)
po/pl.po | 1373 ++++++++++++++++++--------------------------------------------
1 file changed, 392 insertions(+), 981 deletions(-)
commit 7c9d87fa22f3e3fa04b969ec95eb74b8ec063437
Author: Seong-ho Cho <darkcircle.0426@gmail.com>
Date: Wed Mar 27 12:08:32 2024 +0100
po: update ko.po (from translationproject.org)
po/ko.po | 1263 +++++++++++++++++++++-----------------------------------------
1 file changed, 415 insertions(+), 848 deletions(-)
commit 1d8ebc91abd638c58a429e49b324185dc261501f
Author: Takeshi Hamasaki <hmatrjp@users.sourceforge.jp>
Date: Wed Mar 27 12:08:32 2024 +0100
po: update ja.po (from translationproject.org)
po/ja.po | 667 +++++++++++++++++++--------------------------------------------
1 file changed, 198 insertions(+), 469 deletions(-)
commit e9b557f7e8d0b8279b09346243a8c733aa5818e0
Author: Frédéric Marchal <fmarchal@perso.be>
Date: Wed Mar 27 12:08:32 2024 +0100
po: update fr.po (from translationproject.org)
po/fr.po | 1143 +++++++++++++++++++-------------------------------------------
1 file changed, 354 insertions(+), 789 deletions(-)
commit d92637f884aa0f462a132f88a10196e5a6017c01
Author: Mario Blättermann <mario.blaettermann@gmail.com>
Date: Wed Mar 27 12:08:32 2024 +0100
po: update de.po (from translationproject.org)
po/de.po | 801 ++++++++++++++++++++-------------------------------------------
1 file changed, 255 insertions(+), 546 deletions(-)
commit 3279b862aead9129be4f73e9e02770c27092b43b
Author: Petr PÃsaÅ™ <petr.pisar@atlas.cz>
Date: Wed Mar 27 12:08:32 2024 +0100
po: update cs.po (from translationproject.org)
po/cs.po | 1157 ++++++++++++++++++++------------------------------------------
1 file changed, 372 insertions(+), 785 deletions(-)
commit ecc27ce4973bb29ebb52689a8b8f1700b1053596
Author: Karel Zak <kzak@redhat.com>
Date: Tue Mar 26 12:45:24 2024 +0100
lsipc: fix semaphore USED counter
The code incorrectly counts only with the first item in the linked
list (due to a typo). It seems rather fragile to use "semds" and
"semdsp" as variable names in the same code ...
# lsipc -gs
Old:
KEY ID PERMS OWNER NSEMS RESOURCE DESCRIPTION LIMIT USED USE%
SEMMNI Number of semaphore identifiers 32000 3 0.01%
SEMMNS Total number of semaphores 1024000000 369 0.00%
SEMMSL Max semaphores per semaphore set. 32000 - -
SEMOPM Max number of operations per semop(2) 500 - -
SEMVMX Semaphore max value 32767 - -
Fixed:
KEY ID PERMS OWNER NSEMS RESOURCE DESCRIPTION LIMIT USED USE%
SEMMNI Number of semaphore identifiers 32000 3 0.01%
SEMMNS Total number of semaphores 1024000000 156 0.00%
SEMMSL Max semaphores per semaphore set. 32000 - -
SEMOPM Max number of operations per semop(2) 500 - -
SEMVMX Semaphore max value 32767 - -
Addresses: https://issues.redhat.com/browse/RHEL-30269
Signed-off-by: Karel Zak <kzak@redhat.com>
(cherry picked from commit fa45a6e516065f489b1cfb924ec3fc06960e0839)
sys-utils/lsipc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
commit 2d8ca2cf86309adbeccd07cba36c753e28d12a1b
Author: Thorsten Kukuk <kukuk@suse.com>
Date: Tue Mar 26 14:00:57 2024 +0100
libmount: don't initialize variable twice (#2714)
Signed-off-by: Thorsten Kukuk <kukuk@suse.com>
(cherry picked from commit 5509e9b18a4b956b910fff772b9f88880ae28ca1)
libmount/src/hook_loopdev.c | 4 ----
1 file changed, 4 deletions(-)
commit caf7bc5de17653969db94a846b26e0a0f89f93a6
Author: Karel Zak <kzak@redhat.com>
Date: Tue Mar 26 16:18:25 2024 +0100
tests: update build tests
Signed-off-by: Karel Zak <kzak@redhat.com>
tests/expected/build-sys/config-all | 16 +++++++++++-----
tests/expected/build-sys/config-all-non-nls | 16 +++++++++++-----
tests/expected/build-sys/config-audit | 14 ++++++++++----
tests/expected/build-sys/config-chfnsh-libuser | 14 ++++++++++----
tests/expected/build-sys/config-chfnsh-no-password | 14 ++++++++++----
tests/expected/build-sys/config-chfnsh-pam | 14 ++++++++++----
tests/expected/build-sys/config-core | 14 ++++++++++----
tests/expected/build-sys/config-cryptsetup | 16 +++++++++++-----
tests/expected/build-sys/config-devel | 16 +++++++++++-----
tests/expected/build-sys/config-devel-non-asan | 16 +++++++++++-----
tests/expected/build-sys/config-devel-non-docs | 16 +++++++++++-----
tests/expected/build-sys/config-non-libblkid | 12 +++++++++---
tests/expected/build-sys/config-non-libmount | 12 +++++++++---
tests/expected/build-sys/config-non-libs | 11 ++++++++---
tests/expected/build-sys/config-non-libsmartcols | 21 +++++++++++++--------
tests/expected/build-sys/config-non-libuuid | 14 ++++++++++----
tests/expected/build-sys/config-non-nls | 14 ++++++++++----
tests/expected/build-sys/config-non-widechar | 4 ++++
tests/expected/build-sys/config-selinux | 14 ++++++++++----
tests/expected/build-sys/config-slang | 14 ++++++++++----
tests/expected/build-sys/config-static | 14 ++++++++++----
21 files changed, 209 insertions(+), 87 deletions(-)
commit 272c3639d7bdb5f455717d8ce7cd9638419754b6
Author: Karel Zak <kzak@redhat.com>
Date: Tue Mar 26 16:17:29 2024 +0100
autotools: add dependence on libsmartcols for lsclocks
Signed-off-by: Karel Zak <kzak@redhat.com>
configure.ac | 1 +
1 file changed, 1 insertion(+)
commit 2ce9db216050e6ee58b5d62fa8e0de9e459f5eb9
Author: Thorsten Kukuk <kukuk@suse.com>
Date: Tue Mar 26 10:50:30 2024 +0100
more: remove second check for EOF (#2714)
The second EOF check (c == EOF) will never be reached.
Signed-off-by: Thorsten Kukuk <kukuk@suse.com>
(cherry picked from commit 81184ad44f536f7f66175ef59fe8472760357fe8)
text-utils/more.c | 3 ---
1 file changed, 3 deletions(-)
commit 76be93e4ab37ed5e31de2fc8ec6207b082491162
Author: Thorsten Kukuk <kukuk@suse.com>
Date: Tue Mar 26 09:49:22 2024 +0100
uuidgen: use xmalloc instead of malloc (#2714)
Use xmalloc to make sure we don't reference a NULL pointer in error
case.
Signed-off-by: Thorsten Kukuk <kukuk@suse.com>
(cherry picked from commit 0b14dcd755565f3e48f4c30011b3dfe783558393)
misc-utils/uuidgen.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
commit 026aff5e82c288d571b799891dad640504342e35
Author: Thorsten Kukuk <kukuk@suse.com>
Date: Tue Mar 26 09:33:32 2024 +0100
lscpu: initialize all variables (#2714)
cpu->bookid got initialized twice instead of drawerid
Signed-off-by: Thorsten Kukuk <kukuk@suse.com>
(cherry picked from commit 21b9f4a5cdc30e947ff9fb0210dc38ae4b16004c)
sys-utils/lscpu-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit a36ad2d8dbf75760948fe149f0ce3987872f5c57
Author: Tim Hallmann <tim@t8w.de>
Date: Sun Mar 24 20:14:30 2024 +0100
rev: Check for wchar conversion errors
Commit c9cc84621ca98ef85499e83ca56f05f12055f193 introduced a regression
where only the actual EOF is handled, not other error conditions
returning WEOF. This leads to an infinite loop upon encountering
conversion errors. For example (using LC_CTYPE="en_US.UTF-8"):
$ printf '\x80' | rev
Signed-off-by: Tim Hallmann <tim@t8w.de>
(cherry picked from commit a610cf8231a02163a4a2b2faf3047d24798fe180)
text-utils/rev.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
commit 70f403b2218531cb2c77f6c33011bd2559e730d6
Author: Thomas Weißschuh <thomas@t-8ch.de>
Date: Tue Mar 19 22:49:31 2024 +0100
lscpu: restructure op-mode printing
The existing logic can confuse ASAN.
Restructure it so it is shorter and easer to understand for humans.
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
(cherry picked from commit 0477ce4805de4f0f01e98b04ed9acf4168ed805e)
sys-utils/lscpu.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
commit fd8fd209a53647bbbf9e15e4a323ce94fc3c75f9
Author: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
Date: Sat Mar 23 13:39:55 2024 +0530
sys-utils: hwclock-rtc: fix pointer usage
passing double pointer doesn't fill param value
Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
(cherry picked from commit 1064a53e4ff357dc649a8c4a0a41dfb5a1191bba)
sys-utils/hwclock-rtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit 175af5cb8e0434bbc6660f7ccbea3a188d8f2d72
Author: Karel Zak <kzak@redhat.com>
Date: Wed Mar 20 16:08:16 2024 +0100
libmount: make sure "option=" is used as string
mount(8) cares about case when option specified as "name=" (it means
without data). See for example 727c689908c5e68c92aa1dd65e0d3bdb6d91c1e5.
We need this also for new mount API and use FSCONFIG_SET_STRING rather
than FSCONFIG_SET_FLAG.
strace -e fsconfig ./mount -o usrjquota= /dev/sdc1 /mnt/test
Old:
fsconfig(3, FSCONFIG_SET_STRING, "source", "/dev/sdc1", 0) = 0
fsconfig(3, FSCONFIG_SET_FLAG, "usrjquota", NULL, 0) = -1 EINVAL (Invalid argument)
Fixed:
fsconfig(3, FSCONFIG_SET_STRING, "source", "/dev/sdc1", 0) = 0
fsconfig(3, FSCONFIG_SET_STRING, "usrjquota", "", 0) = 0
Fixes: https://github.com/util-linux/util-linux/issues/2837
Signed-off-by: Karel Zak <kzak@redhat.com>
(cherry picked from commit 0c5485348b155420ecd1bfcdabb1b869ca5ee3c2)
libmount/src/hook_mount.c | 3 +++
libmount/src/mountP.h | 1 +
libmount/src/optlist.c | 14 +++++++++++++-
3 files changed, 17 insertions(+), 1 deletion(-)
commit 8beae411393d565778a80d3513be8b68bf5967fa
Author: Jordan Williams <jordan@jwillikers.com>
Date: Wed Mar 20 11:41:49 2024 -0500
meson: Only build blkzone and blkpr if the required linux header exists
Checks for the required headers for blkzone and blkptr are done for
Autotools.
This logic wasn't carried over to Meson.
This PR just adds the same checks.
Fixes #2850.
Signed-off-by: Jordan Williams <jordan@jwillikers.com>
(cherry picked from commit 1a374511693e4b2e8e53966615ce9112553d3b08)
meson.build | 42 +++++++++++++++++++++++-------------------
1 file changed, 23 insertions(+), 19 deletions(-)
commit 4f057203f9baf1dc3cee452f5ac6cd53499df750
Author: Stanislav Brabec <sbrabec@suse.cz>
Date: Mon Mar 18 18:39:36 2024 +0100
chcpu(8): document limitations of -g
Document that chcpu -g is not supported on IBM z/VM because the detach cpu
would CLEAR the running zVM guest memory.
References:
https://www.ibm.com/docs/en/linux-on-z?topic=mc-changing-state-1
https://www.ibm.com/docs/en/zvm/7.3?topic=commands-detach-cpu
Reported-by: Heikki Ylipiessa <heikki.ylipiessa@suse.com>
Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
(cherry picked from commit 7d16145c4696772bb5438a43a482f68fbf046370)
sys-utils/chcpu.8.adoc | 2 ++
1 file changed, 2 insertions(+)
commit c2484e78d19184ae120981aab34341da046cb6a0
Author: Karel Zak <kzak@redhat.com>
Date: Wed Mar 20 15:03:05 2024 +0100
lib/sha1: fix for old glibc
Fixes: https://github.com/util-linux/util-linux/issues/2830
References: http://github.com/util-linux/util-linux/commit/a8902e4cdd6149e5124383b25db8688dcdacd790
Signed-off-by: Karel Zak <kzak@redhat.com>
(cherry picked from commit 4ebdd569049ac48a3867a59537cea769fa319e8f)
lib/sha1.c | 4 ++++
1 file changed, 4 insertions(+)
commit 6baf2ea1d3a64dbe198b333c34a5284247c87b5f
Author: Karel Zak <kzak@redhat.com>
Date: Wed Mar 20 14:42:28 2024 +0100
lscpu: don't use NULL sharedmap
Fixes: https://github.com/util-linux/util-linux/issues/2846
Signed-off-by: Karel Zak <kzak@redhat.com>
(cherry picked from commit 9ce09ccc3c8eee9be4fb5f33ae382d92c69dc411)
sys-utils/lscpu-topology.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
commit 806d26e41e2b0338b4f4549cb6a6d7b729bb1a14
Merge: 1d9a3384f 3f1598482
Author: Karel Zak <kzak@redhat.com>
Date: Wed Mar 20 14:33:35 2024 +0100
Merge branch 'test_mkfds-sockdiag' of https://github.com/masatake/util-linux into stable/v2.40
* 'test_mkfds-sockdiag' of https://github.com/masatake/util-linux:
tests: (lsfd) skip some cases if NETLINK_SOCK_DIAG for AF_UNIX is not available
tests: (test_mkfds::sockdiag) new factory
tests: (lsfd-functions.bash,cosmetic) unify the style to define functions
tests: (lsfd) fix typoes in an error name
commit 1d9a3384fd1ed4789644829e29a5eb64fbbe75fd
Author: Thomas Weißschuh <thomas@t-8ch.de>
Date: Tue Mar 19 22:21:54 2024 +0100
ci: reduce aslr level to avoid issues with ASAN
As we have multiple different configurations using ASAN just disable it
for all of them.
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
(cherry picked from commit c74ccea0af4d0354be60cece679b63de7f06400d)
.github/workflows/cibuild-setup-ubuntu.sh | 3 +++
1 file changed, 3 insertions(+)
commit c706b31e8fa42ccdb19588f36569f6799ba71323
Author: biubiuzy <294772273@qq.com>
Date: Fri Feb 23 17:44:12 2024 +0800
last: avoid out of bounds array access
(cherry picked from commit 75822efb8e948b538d9e9ccc329a5430fdabb7ea)
login-utils/last.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
commit 95df581c4683e6ecb058c38c30bbade184566de0
Author: Matt Turner <mattst88@gmail.com>
Date: Mon Mar 18 21:29:13 2024 -0400
libmount: Fix export of mnt_context_is_lazy and mnt_context_is_onlyonce
[kzak@redhat.com: - fix also function docs]
Bug: https://bugs.gentoo.org/927258
Closes: https://github.com/util-linux/util-linux/issues/2844
Fixes: 3d1c41c8c ("libmount: add --onlyonce")
Signed-off-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
(cherry picked from commit 6d2917f2eb910fb8bcdc6476be18c34fee152911)
libmount/src/context.c | 4 ++--
libmount/src/libmount.sym | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
commit 872ea8479c8c3d282e9ee39419d4af252dbad4ee
Author: Chris Hofstaedtler <zeha@debian.org>
Date: Fri Mar 15 17:54:17 2024 +0100
findmnt: remove deleted option from manual
Bug-Debian: 1066843
Signed-off-by: Chris Hofstaedtler <zeha@debian.org>
Reported-by: Francesco Potortì <Potorti@isti.cnr.it>
(cherry picked from commit f494d3f8c33ffd5c98716717a7fe974ae0e9d08a)
misc-utils/findmnt.8.adoc | 3 ---
1 file changed, 3 deletions(-)
commit f685c8a35667ddb99c400d7f95b49f389b4dd078
Author: Kuniyuki Iwashima <kuniyu@amazon.com>
Date: Mon Mar 11 18:12:02 2024 +0000
lib/pty-session: Don't ignore SIGHUP.
The blamed commit converted script to use the generic pty code that
was added by commit 6954895cae34 ("lib/pty-session: add generic PTY
container code").
Commit ec10634e7ec4 says the new pty stuff is based on script.
However, there is difference in signal handling.
Before the commit, only the signals that the script was interested
in were blocked and handled by signalfd.
After the commit, all signals are blocked and only the interested
signals are handled.
This causes regression in the following scenario:
1. run `script` via /etc/profile.d for ssh session
2. login to a ssh session using bash
3. run `sudo -i`
4. wait until ssh session timeout
After 3., the process tree will be like this.
$ pstree -p | grep script
|-sshd(2652)-sshd(637993)---sshd(637996)---bash(637997)---script(638028)---bash(638029)---sudo(638057)---sudo(638059)-+
The notable thing here is that script is in the parent's process
group (637997).
$ ps -eo pid,pgid,ppid,stat,sig,comm | grep script
638028 637997 637997 S+ 0000000000000000 script
Thus, the parent bash will send SIGHUP to script, when the timeout
occurs at 4.
$ sudo /usr/share/bcc/tools/killsnoop
TIME PID COMM SIG TPID RESULT
18:46:57 637997 bash 1 637997 0
$ ps -eo pid,pgid,ppid,stat,sig,comm | grep script
638028 637997 1 S 0000000000020001 script
However, this is not handled, so the script is reaped but remains
forever.
$ pstree -p | grep script
|-script(638028)---bash(638029)
To avoid such a situation, we need to handle SIGHUP in script.
With this patch, script will receive SIGHUP from the parrent and
kill its child processes.
$ pstree -p | grep script
|-sshd(2652)-sshd(638400)---sshd(638404)---bash(638405)---script(638436)---bash(638437)---sudo(638465)---sudo(638467)-+
$ sudo /usr/share/bcc/tools/killsnoop
TIME PID COMM SIG TPID RESULT
18:50:11 638405 bash 1 638405 0
18:50:11 638436 script 15 638437 0
18:50:11 638436 script 15 638437 0
18:50:13 638436 script 9 638437 0
Fixes: ec10634e7ec4 ("script: use lib/pty-session")
Reported-by: Ayame Suzuki <ayameszk@amazon.co.jp>
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
(cherry picked from commit e35f22bc05802001a806b82a82be41e345cc1dea)
lib/pty-session.c | 3 +++
1 file changed, 3 insertions(+)
commit 3f159848259541cb912e53eed093926e957beeae
Author: Masatake YAMATO <yamato@redhat.com>
Date: Sat Mar 16 22:20:00 2024 +0900
tests: (lsfd) skip some cases if NETLINK_SOCK_DIAG for AF_UNIX is not available
Close #2822.
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
tests/ts/lsfd/mkfds-socketpair | 3 +++
tests/ts/lsfd/mkfds-unix-stream-requiring-sockdiag | 2 ++
2 files changed, 5 insertions(+)
commit 9b1369f2d1215c0c803558c2263378980b4310d7
Author: Masatake YAMATO <yamato@redhat.com>
Date: Sat Mar 16 22:07:43 2024 +0900
tests: (test_mkfds::sockdiag) new factory
The factory is for detecting whether a platform provides
NETLINK_SOCK_DIAG sockets for a given family.
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
tests/helpers/test_mkfds.c | 114 ++++++++++++++++++++++++++++++++++++++
tests/ts/lsfd/lsfd-functions.bash | 27 +++++++++
2 files changed, 141 insertions(+)
commit 49770efea829d1df8cbb7c225e5cc2c9ae6c9444
Author: Masatake YAMATO <yamato@redhat.com>
Date: Sat Mar 16 22:05:48 2024 +0900
tests: (lsfd-functions.bash,cosmetic) unify the style to define functions
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
tests/ts/lsfd/lsfd-functions.bash | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
commit 8ea40ca412aeb808e273781007f8e33e9f7aede7
Author: Masatake YAMATO <yamato@redhat.com>
Date: Sun Mar 17 00:38:17 2024 +0900
tests: (lsfd) fix typoes in an error name
tests/helpers/test_mkfds.c | 6 +++---
tests/ts/lsfd/lsfd-functions.bash | 2 +-
tests/ts/lsfd/mkfds-ping | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
commit 81c528c4fc4a31e9c8de04eb96e64be9e3967697
Author: Tanish Yadav <devtany@gmail.com>
Date: Tue Mar 5 00:51:41 2024 +0530
su: fix use after free in run_shell
Do not free tmp for non login branch as basename may return a pointer to
some part of it.
[kzak@redhat.com: - improve coding style of the function]
Signed-off-by: Tanish Yadav <devtany@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
(cherry picked from commit 4b2e6f5071a4c5beebbd9668d24dc05defc096d7)
login-utils/su-common.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
commit c8fd2a4d6d5a9ad504e4eff71efa040ca5bb459b
Author: Karel Zak <kzak@redhat.com>
Date: Mon Mar 4 13:30:10 2024 +0100
su, agetty: don't use program_invocation_short_name for openlog()
Make sure the program name is hardcoded when write to the log.
Reported-by: "Serge E. Hallyn" <serge@hallyn.com>
Reported-by: "Skyler Ferrante (RIT Student)" <sjf5462@rit.edu>
Signed-off-by: Karel Zak <kzak@redhat.com>
(cherry picked from commit 677a3168b261f3289e282a02dfd85d7f37de0447)
login-utils/su-common.c | 2 +-
term-utils/agetty.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
commit 7d30d756e66068173a6a6dd30e549933e392f523
Author: Jakub Wilk <jwilk@jwilk.net>
Date: Fri Mar 1 10:33:46 2024 +0100
docs: fix typos
Signed-off-by: Jakub Wilk <jwilk@jwilk.net>
(cherry picked from commit 292586e4a6e887d37134db446c6dbd2c7a046d86)
Documentation/howto-contribute.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
commit 490850cb245776922bbe6d7b33bf8070bbbf851b
Author: Karel Zak <kzak@redhat.com>
Date: Thu Feb 29 23:00:10 2024 +0100
docs: add note about stable branches
Signed-off-by: Karel Zak <kzak@redhat.com>
(cherry picked from commit 67cdedd639f3ea285fe8d1508ad208334760e5cb)
Documentation/howto-contribute.txt | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
commit d283c67c3e84595fdd6a67fe7a07a4b805cd4f8c
Author: Karel Zak <kzak@redhat.com>
Date: Mon Mar 4 12:35:09 2024 +0100
build-sys: make sure everywhere is localstatedir
_PATH_LOCALSTATEDIR and @localstatedir@ are defined by build-systems
and it's necessary to use it everywhere to keep things consistent.
Reference: https://github.com/util-linux/util-linux/pull/2825
Signed-off-by: Karel Zak <kzak@redhat.com>
(cherry picked from commit 720301e04f339274652150f305d9e9f3e504ac6e)
liblastlog2/src/lastlog2.h | 2 +-
misc-utils/uuidd.service.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
commit 4069411ca37b2769b0e39dae749a5875e50fc422
Author: Masatake YAMATO <yamato@redhat.com>
Date: Sun Mar 3 06:51:15 2024 +0900
tests: (lsfd::mkfds-inotify) consider environments not having / as a mount point
Close #2819.
In the original test case, test_mkfds monitored / and /etc/fstab.
As reported in #2819, if a test platform doesn't have / as a
mount point, the test case doesn't work.
So we use /proc and /proc/cmdnline instead.
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Acked-by: Chris Hofstaedtler <zeha@debian.org>
(cherry picked from commit 121b37036cce04f5d6bf590d6eef13ecf8a09265)
tests/expected/lsfd/mkfds-inotify | 2 +-
tests/ts/lsfd/mkfds-inotify | 18 ++++++++++--------
2 files changed, 11 insertions(+), 9 deletions(-)